1592509 - Enable gfx.webrender.compositor by default on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Sotaro Ikeda [:sotaro]]

Bug 1591004 is not enough for enabling os compositor on Windows.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1592509 - Enable gfx.webrender.compositor by default on Windows

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=62451dea278e50cbbec6a3144bc7f14625b5ff93

Comment 3

[Sotaro Ikeda [:sotaro]]

Thre are some regressions(glterrain, tart, tp5o_scroll, tscrollx, tsvg_static and tsvgr_opacity). They are expected regression as in Bug 1595437 Comment 13.
talos
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=1e248fde99dc28880cf69807734db4079769d976&newProject=try&newRevision=003913941b9d253608cecf6319ea9c709ed9866e&framework=1

raptor
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=2bdacbd35904fa7a18ddefaee81f006262dcadfc&newProject=try&newRevision=134ba49a38456d922dce834d9759ef16d07a5cd8&framework=10

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c12330a620c4
Enable gfx.webrender.compositor by default on Windows r=gw

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c12330a620c4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

For posterity, bug 1604088 disabled this on m-c.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1592509 - Re-enable gfx.webrender.compositor by default on Windows

Comment 8

[Sotaro Ikeda [:sotaro]]

Current WR compositor usage caused a lot of reftest failures that did not happen in Comment 5 :(
https://treeherder.mozilla.org/#/jobs?repo=try&revision=878b1344aba802158b04c87d8b07ab61faf3601f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd2634c753b9
Re-enable gfx.webrender.compositor by default on Windows r=gw,jrmuizel

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cd2634c753b9

Comment 11

[:Gijs (he/him)]

AFAICT this didn't make 73.

Comment 12

[5silentrain]

I have the dev version 75.0b11 installed. The about:support page indicates the following:
WEBRENDER_COMPOSITOR: blacklisted by runtime: Blacklisted

Screenshot: https://imgur.com/LzqF0ec

Why?! O__O In previous beta versions, everything was fine!!!
My graphics card is AMD Radeon RX Vega M GH.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

(In reply to 5silentrain from comment #12)

I have the dev version 75.0b11 installed. The about:support page indicates the following:
WEBRENDER_COMPOSITOR: blacklisted by runtime: Blacklisted

Screenshot: https://imgur.com/LzqF0ec

Why?! O__O In previous beta versions, everything was fine!!!
My graphics card is AMD Radeon RX Vega M GH.

We're currently blocking DirectComposition in late beta and release on AMD hardware to minimize risk. We'll eventually turn it on AMD hardware.

You'll get DirectComposition again once beta switches to 76 or you could switch to using Nightly.

Comment 14

[5silentrain]

Okay! I will look forward to the 76th version 🙂 DirectComposition works on my graphics card (AMD Radeon RX Vega M GH) without any problems 👍

Comment 15

[5silentrain]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #13)

(In reply to 5silentrain from comment #12)

I have the dev version 75.0b11 installed. The about:support page indicates the following:
WEBRENDER_COMPOSITOR: blacklisted by runtime: Blacklisted

Screenshot: https://imgur.com/LzqF0ec

Why?! O__O In previous beta versions, everything was fine!!!
My graphics card is AMD Radeon RX Vega M GH.

We're currently blocking DirectComposition in late beta and release on AMD hardware to minimize risk. We'll eventually turn it on AMD hardware.

You'll get DirectComposition again once beta switches to 76 or you could switch to using Nightly.

DirectComposition worked in version 76.0b5 👌 Today updated to version 76.0b6. DirectComposition does not work again 😫 The about:support page indicates the following: https://imgur.com/eIPN2no

Comment 16

[Darkspirit]

That's bug 1631312.

Comment 17

[5silentrain]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #16)

That's bug 1631312.

So this is a bug? 🤨 Is it already fixed?

Comment 18

[Darkspirit]

Yes. The "Tracking" section of bug 1631312 is expanded by default: It tells that this has been fixed in Nightly 77 (2 hours ago: bug 1631312 comment 4) and awaits a patch uplift to Beta 76 (affected + tracking requested). The "References" section tells that this was caused by bug 1630629 yesterday. The fix of bug 1630629 had not been verified in Nightly (bug 1630629 comment 5), so it was merged untested into Beta.

Comment 19

[5silentrain]

Today, Firefox has been updated to version 76.0b7. The bug is still present 😕

Comment 20

[:Gijs (he/him)]

(In reply to 5silentrain from comment #19)

Today, Firefox has been updated to version 76.0b7. The bug is still present 😕

I'm pretty sure comment #16 is unrelated and comment #13 explains this. It'll be turned on on early beta (betas 1-5) each cycle and turned off in late beta (beta 6 and later) to be closer to what we release -- until there's a decision to release with it enabled on AMD hardware. Until that happens, if you want this enabled, we suggest you use nightly (as per comment #13).

Jeff, is there a separate bug on file on directcomposition enabling by default on release / late beta for AMD hardware users that people can follow?

5silentrain, out of interest, is there a particular reason why you need directcomposition to be enabled? What breaks or works poorly without it?

Comment 21

[5silentrain]

(In reply to :Gijs (he/him) from comment #20)

5silentrain, out of interest, is there a particular reason why you need directcomposition to be enabled? What breaks or works poorly without it?

The problem I described here appears: https://bugzilla.mozilla.org/show_bug.cgi?id=1591218
With DirectComposition enabled, everything starts working perfectly!

Comment 22

[5silentrain]

You can open any video on YouTube in full screen mode and start pressing the Win key on the keyboard many times. If DirectComposition is disabled, this will lead to strong jerking of the video. At least this applies to my computer.

Comment 23

[5silentrain]

Also, the problem goes away if I force disable "WebRender" on the about:config page (the parameter "gfx.webrender.force-disabled"). In "Direct3D 11 (Advanced Layers)" mode, everything works fine 👌

Comment 24

[Jeff Muizelaar [:jrmuizel]]

This should get better with bug 1632239 which is landing now.